Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improved wording #28139

Merged
merged 1 commit into from
Jul 24, 2023
Merged

improved wording #28139

merged 1 commit into from
Jul 24, 2023

Conversation

jojo259
Copy link
Contributor

@jojo259 jojo259 commented Jul 24, 2023

wording was awkward.

there are a few options:

  • "some mandatory and others optional" (my choice)
  • "some mandatory and some optional"
  • "some are mandatory and others are optional"
  • "some are mandatory and some are optional"

@jojo259 jojo259 requested a review from a team as a code owner July 24, 2023 03:53
@jojo259 jojo259 requested review from teoli2003 and removed request for a team July 24, 2023 03:53
@github-actions github-actions bot added the Content:HTTP HTTP docs label Jul 24, 2023
@github-actions
Copy link
Contributor

Preview URLs

wbamberg
wbamberg approved these changes Jul 24, 2023
View reviewed changes
Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thank you @jojo259 , this is much better!

@wbamberg wbamberg merged commit b5f301c into mdn:main Jul 24, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wbamberg wbamberg wbamberg approved these changes

@teoli2003 teoli2003 Awaiting requested review from teoli2003 teoli2003 is a code owner automatically assigned from mdn/yari-content-http

Assignees
No one assigned
Labels
Content:HTTP HTTP docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jojo259 @wbamberg